-
Notifications
You must be signed in to change notification settings - Fork 12
Yarn version upgrade #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Yarn version upgrade #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michał Leszczyk <michal.leszczyk@avalabs.org>
gergelylovas
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
Seems like some changes are needed to the .github/workflow
files to pass CI checks. Error: Cannot find module '/home/runner/work/core-extension/core-extension/.yarn/releases/yarn-4.5.3.cjs'
.
Co-authored-by: Gergely Lovas <gergely.lovas@avalabs.org>
Co-authored-by: Gergely Lovas <gergely.lovas@avalabs.org>
…abs#126) Signed-off-by: Ryan W <ryan40wood@gmail.com> Co-authored-by: bferenc <117105626+bferenc@users.noreply.github.com>
…on into yarn-version-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to update the version of the yarn package manager to the latest stable version: 4.5.3
Changes
packageManager
property in thepackage.json
fileresolutions
(This was required because the previous setup got removed when runningyarn install
after the yarn version upgrade)minimatch
nth-check
glob-parent
allowScripts
which was visible in the console after running thepostinstall
scriptTesting
I run all the scripts in
package.json
, apart from thesentry
(which I assume needs some additional setup) run without any problem.Obviously some additional testing is required, to really make sure nothing is broken
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.
I've covered new/modified business logic with Jest test cases.N/A