Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve swap failure messaging & log them to Sentry #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: improve swap failure messaging & log them to Sentry #129

wants to merge 2 commits into from

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Jan 30, 2025 •
edited
Loading

Description

Changes

  • Improves messaging of possible swap failures (avoid generic Swap Failed toast message)
  • Logs failures to Sentry

Testing

Make swap transactions fail. For example:

  • block Paraswap in dev tools
  • in two-step swaps, approve spend limit, revoke it and then approve the 2nd transaction
  • modify code

Screenshots:

image

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meeh0w