-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-9960] appcheck improvements #159
Conversation
…om/ava-labs/core-extension into feat/CP-9960-appcheck-imporvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked nicely in Chrome, but I didn't see the requests in Brave. I probably need to toggle that settings you guys mentioned, but I forgot what it was 😬 If you LMK, I can run that test again.
Tested in Brave as well, works nicely :)
Description
Prevent firebase initialization in unsupported browsers.
Changes
FirebaseService
Testing
The extension should still generate appcheck tokens for Chrome and Brave, but not for other browsers.
Screenshots:
Reverse challenge duration
Chrome
Brave
Edge
Checklist for the author
Tick each of them when done or if not applicable.