Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-9960] appcheck improvements #159

Merged
merged 11 commits into from
Feb 28, 2025
Merged

Conversation

bferenc
Copy link
Contributor

@bferenc bferenc commented Feb 25, 2025

Description

Prevent firebase initialization in unsupported browsers.

Changes

  • adds a new "reverse" challenge
  • increases token fetch timeout to match the token's expiry
  • introduces timeouts for registration and verification
  • ignores push service registration errors
  • adds a browser type check to FirebaseService

Testing

The extension should still generate appcheck tokens for Chrome and Brave, but not for other browsers.

Screenshots:

Reverse challenge duration

image

Chrome

image

Brave

image

Edge

image

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Copy link
Contributor

@csabbee csabbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-

Copy link
Member

@meeh0w meeh0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked nicely in Chrome, but I didn't see the requests in Brave. I probably need to toggle that settings you guys mentioned, but I forgot what it was 😬 If you LMK, I can run that test again.

Tested in Brave as well, works nicely :)

@bferenc bferenc merged commit b251bd0 into main Feb 28, 2025
6 checks passed
@bferenc bferenc deleted the feat/CP-9960-appcheck-imporvements branch February 28, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants