Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always sign uptime messages (testing branch) #1269

Draft
wants to merge 7 commits into
base: always-sign-uptime-types
Choose a base branch
from
Draft

always sign uptime messages (testing branch) #1269

wants to merge 7 commits into from
+41 −0

Conversation

darioush
Copy link
Collaborator

@darioush darioush commented Aug 6, 2024 •
edited
Loading

There is definitely some room for improvement but this branch should:

  • Unblock the work for ACP-77 / interop
  • Launch some discussion about how we will handle signing of dynamic messages (with actual uptime tracking), at minimum the caching behavior should be decided.

Can also shuffle this code around if there is some strong preferences.

@darioush darioush added the DO NOT MERGE This PR is not meant to be merged in its current state label Aug 6, 2024
Base automatically changed from update-avalanchego to master August 12, 2024 15:59
@darioush darioush changed the base branch from master to always-sign-uptime-types August 19, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur will be requested when the pull request is marked ready for review ceyonur is a code owner

Assignees
No one assigned
Labels
DO NOT MERGE This PR is not meant to be merged in its current state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@darioush