-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validator state #1344
Closed
Closed
add validator state #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
darioush
reviewed
Sep 17, 2024
go.mod
Outdated
@@ -5,7 +5,7 @@ go 1.21.12 | |||
require ( | |||
github.com/VictoriaMetrics/fastcache v1.12.1 | |||
github.com/antithesishq/antithesis-sdk-go v0.3.8 | |||
github.com/ava-labs/avalanchego v1.11.11 | |||
github.com/ava-labs/avalanchego v1.11.12-0.20240910093928-8c6a486205ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you link the modified avalanchego branch in the PR description?
Changed the target branch to |
darioush
reviewed
Sep 19, 2024
darioush
reviewed
Sep 19, 2024
darioush
previously approved these changes
Sep 23, 2024
* windows ci: remove cr before comparing to known_flakes.txt * try * try * try
* fix ci: linux ci doesn't have dos2unix * remove dupe
* update avalanchego dep branch * fix upgrades after deactivating latest in context * use branch commit for ava version * bump avago * bump go * restore format changes --------- Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
* Bump avalanchego to master * always sign uptime messages (testing branch) * nits * cleanup * assign to correct `err` * fix handler * move ValidatorUptime type to subnet-evm * disable always signing * implement on the type itself * remove unneeded code * fix ut --------- Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
* add standalone dbs and configs * show value in config * fix tests * move to vm * remove the noSkip flag * reviews * check isMemDB earlier * rename var * return nit --------- Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
ceyonur
added
the
DO NOT MERGE
This PR is not meant to be merged in its current state
label
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds validator state that can persist validator information and implements
uptime.State
.How this was tested
Added UT
How is this documented
Comments in code