Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validator state #1344

Closed
wants to merge 16 commits into from
Closed

add validator state #1344

wants to merge 16 commits into from

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Sep 16, 2024

Why this should be merged

Adds validator state that can persist validator information and implements uptime.State.

How this was tested

Added UT

How is this documented

Comments in code

@ceyonur ceyonur mentioned this pull request Sep 16, 2024
@ceyonur ceyonur marked this pull request as ready for review September 17, 2024 15:08
@ceyonur ceyonur requested review from darioush and a team as code owners September 17, 2024 15:08
plugin/evm/validators/state.go Outdated Show resolved Hide resolved
plugin/evm/validators/state.go Outdated Show resolved Hide resolved
plugin/evm/validators/state.go Outdated Show resolved Hide resolved
plugin/evm/validators/state.go Outdated Show resolved Hide resolved
plugin/evm/validators/state.go Outdated Show resolved Hide resolved
plugin/evm/validators/state_test.go Outdated Show resolved Hide resolved
plugin/evm/validators/state_test.go Outdated Show resolved Hide resolved
go.mod Outdated
@@ -5,7 +5,7 @@ go 1.21.12
require (
github.com/VictoriaMetrics/fastcache v1.12.1
github.com/antithesishq/antithesis-sdk-go v0.3.8
github.com/ava-labs/avalanchego v1.11.11
github.com/ava-labs/avalanchego v1.11.12-0.20240910093928-8c6a486205ce
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link the modified avalanchego branch in the PR description?

plugin/evm/validators/state.go Outdated Show resolved Hide resolved
plugin/evm/validators/state.go Outdated Show resolved Hide resolved
@ceyonur ceyonur changed the base branch from master to uptime-tracking-base September 19, 2024 17:47
@ceyonur
Copy link
Collaborator Author

ceyonur commented Sep 19, 2024

Changed the target branch to uptime-tracking-base since these PRs should not be merged to master as they depend on a avalanchego feature branch that not merged yet.

darioush
darioush previously approved these changes Sep 23, 2024
* windows ci: remove cr before comparing to known_flakes.txt

* try

* try

* try
@ceyonur ceyonur self-assigned this Sep 26, 2024
darioush and others added 4 commits September 27, 2024 11:10
* fix ci: linux ci doesn't have dos2unix

* remove dupe
* update avalanchego dep branch

* fix upgrades after deactivating latest in context

* use branch commit for ava version

* bump avago

* bump go

* restore format changes

---------

Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
Base automatically changed from uptime-tracking-base to master October 7, 2024 17:44
@ceyonur ceyonur dismissed darioush’s stale review October 7, 2024 17:44

The base branch was changed.

ceyonur and others added 8 commits October 14, 2024 12:02
* Bump avalanchego to master

* always sign uptime messages (testing branch)

* nits

* cleanup

* assign to correct `err`

* fix handler

* move ValidatorUptime type to subnet-evm

* disable always signing

* implement on the type itself

* remove unneeded code

* fix ut

---------

Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
* add standalone dbs and configs

* show value in config

* fix tests

* move to vm

* remove the noSkip flag

* reviews

* check isMemDB earlier

* rename var

* return nit

---------

Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
@ceyonur ceyonur added the DO NOT MERGE This PR is not meant to be merged in its current state label Oct 22, 2024
@ceyonur ceyonur changed the base branch from master to pausable-uptime-manager October 28, 2024 18:25
@ceyonur ceyonur deleted the branch pausable-uptime-manager October 28, 2024 18:25
@ceyonur ceyonur closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This PR is not meant to be merged in its current state Uptime Tracking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants