Uptime e2e #637
Open
Uptime e2e #637
+342
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
geoff-vball,
bernard-avalabs and
michaelkaplan13
geoff-vball
previously approved these changes
Nov 1, 2024
cam-schultz
dismissed
geoff-vball’s stale review
Uptime proof validation changed
geoff-vball
approved these changes
Nov 1, 2024
bernard-avalabs
approved these changes
Nov 6, 2024
| * @notice maximumStakeAmount is the maximum amount of stake that can be staked to a validator | ||
| * @notice minimumStakeDuration is the minimum duration that validators must stake for | ||
| * @notice minimumDelegationFeeBips is the minimum delegation fee in basis points that validators can charge | ||
| * @notice maximumStakeMultiplier is multiplier applied to validator's initial stake amount to determine |
There was a problem hiding this comment.
Suggested change
| * @notice maximumStakeMultiplier is multiplier applied to validator's initial stake amount to determine | |
| * @notice maximumStakeMultiplier is the multiplier applied to a validator's initial stake amount to determine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Integrates ava-labs/subnet-evm#1377 to enable constructing signed uptime proofs. The uptime proofs are submitted in the call to
initializeEndValidationandforceInitializeEndValidationfor PoS validators in the e2e tests. Uptime proofs are not supplied for validators that were registered as PoA, since they are not eligible for rewards.Also changes the requirement that the uptime proof be signed by the same chain that the validator manager is deployed on, to instead requiring that it be signed by an
uptimeBlockchainIDthat is supplied at initialization. This chain must be validated by the L1 managed by the validator manager. There is no requirement that the validator manager be deployed on the chain whose validator set it is managing, so the existing check is incorrect.How this works
The helpers that call
initializeEndValidationfirst construct an uptime proof using the helperConstructUptimeProofMessage, signed by the L1.How this was tested
CI
How is this documented
N/A