Centralize reward management in PoSValidatorManager #643
+45
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
force-pushed
the
consolidate-reward-updates
branch
from
005ec21
to
7cb0f4a
Compare
richardpringle
requested review from
iansuvak,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
richardpringle
force-pushed
the
consolidate-reward-updates
branch
from
7cb0f4a
to
7e3c8ff
Compare
richardpringle
commented
Nov 13, 2024
| @@ -760,4 +744,41 @@ abstract contract PoSValidatorManager is | |||
| PoSValidatorManagerStorage storage $ = _getPoSValidatorManagerStorage(); | |||
| return $._posValidatorInfo[validationID].owner != address(0); | |||
| } | |||
|
|
|||
| function _withdrawValidationRewards(address rewardRecipient, bytes32 validationID) internal { | |||
| PoSValidatorManagerStorage storage $ = _getPoSValidatorManagerStorage(); | |||
There was a problem hiding this comment.
Does it make more sense to pass this in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
If any of the reward logic changes, the change happens in one place. For the delegator, the logic only existed in one place before, but this keeps the pattern consistent and improves the readability of
_completeEndDelegationfunction.How this works
Same as before, I just moved code
How this was tested
Existing tests
How is this documented
inline docs on new functions