Closed
Conversation
Member
|
hey @0xSasaPrsic are we checking for duplicates before returning? |
Member
Author
There is no duplicate check. |
Member
|
@0xSasaPrsic we should add one, before returning imo, lemme know if you'd want to understand, how there will be duplicates in the first place |
QEDK
suggested changes
Jun 3, 2025
Contributor
QEDK
left a comment
QEDK
left a comment
There was a problem hiding this comment.
Needs better pagination, please remove immutable from cache header when the data can change in the future.
| let ethereum_sends_results = eth_send_query | ||
| .select(EthereumSend::as_select()) | ||
| .order_by(schema::ethereum_sends::source_timestamp.desc()) | ||
| .limit(state.transactions_result_max_size.into()) |
Contributor
There was a problem hiding this comment.
Please implement pagination with offset and integrate with endpoint.
| let avail_sends_results = avail_send_query | ||
| .select(AvailSend::as_select()) | ||
| .order_by(schema::avail_sends::source_timestamp.desc()) | ||
| .limit(state.transactions_result_max_size.into()) |
0xSasaPrsic
force-pushed
the
expand_transaction_query_result
branch
from
3209cf9 to
7c3c6e5
Compare
0xSasaPrsic
force-pushed
the
expand_transaction_query_result
branch
from
7c3c6e5 to
869da22
Compare
Member
Author
|
Not relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add receiver address transactions that match the query.
Add a var to control the limit of the query.