Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect on action when no_confirmation = true #2038

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

Paul-Bob
Copy link
Contributor

Description

When using no_confirmation on actions the form was getting submitted by JS resulting on UnknownFormat, changing the way that JS submit to actually click on the form button solved the issue.

Fixes https://discord.com/channels/740892036978442260/1174872788323020911

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob added the Fix label Nov 17, 2023
@Paul-Bob Paul-Bob self-assigned this Nov 17, 2023
Copy link

codeclimate bot commented Nov 17, 2023

Code Climate has analyzed commit 22419c8 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit e07ad43 into main Nov 20, 2023
11 of 13 checks passed
@Paul-Bob Paul-Bob deleted the fix/action_redirect_when_no_confirmation branch November 20, 2023 12:29
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@konung
Copy link

konung commented Nov 27, 2023

@Paul-Bob Just ran into the same issue. Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants