Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: sym_link #3110

Merged
merged 1 commit into from
Aug 9, 2024
Merged

performance: sym_link #3110

merged 1 commit into from
Aug 9, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Aug 9, 2024

Description

Fixes #3107

All tests were done on my local machine.

rails avo:sym_link was taking around 6 seconds to execute.

With this improvement, it went down to around 3 seconds, where 90% of the execution time is starting the task, not the actual task code.

The execution time of the code inside the task was decreased drastically.

If the code from the task were executed on a bash script it would cut all the time required for starting the task but we need it on the task to enhance on assets:precompile.

If from the task we call a script instead the execution time is almost the same, there are no significant improvements.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

codeclimate bot commented Aug 9, 2024

Code Climate has analyzed commit 1c2a121 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob self-assigned this Aug 9, 2024
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! let's ship it!

@Paul-Bob Paul-Bob merged commit ece40c9 into main Aug 9, 2024
21 of 23 checks passed
@Paul-Bob Paul-Bob deleted the performance/sym_link branch August 9, 2024 09:05
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract avo:sym_link task to bash script
2 participants