Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change pagy default size to integer #3121

Merged
merged 2 commits into from
Aug 12, 2024
Merged

chore: change pagy default size to integer #3121

merged 2 commits into from
Aug 12, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Aug 12, 2024 •
edited
Loading

Description

Fixes #3049

Dropping the array legacy API in favor of integer.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Aug 12, 2024
@github-actions github-actions bot added the Chore label Aug 12, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Aug 12, 2024 •
edited
Loading

Code Climate has analyzed commit d62a30b and detected 0 issues on this pull request.

View more on Code Climate.

adrianthedev
adrianthedev reviewed Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still work with pagy < 9?

@Paul-Bob
Copy link
Contributor Author

Does this still work with pagy < 9?

Not with the current changes

@Paul-Bob Paul-Bob marked this pull request as draft August 12, 2024 07:37
@Paul-Bob Paul-Bob marked this pull request as ready for review August 12, 2024 07:57
@Paul-Bob Paul-Bob merged commit 23404ea into main Aug 12, 2024
21 of 22 checks passed
@Paul-Bob Paul-Bob deleted the chore/change_pagy_default_size_to_integer branch August 12, 2024 10:39
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees

@Paul-Bob Paul-Bob

Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use integer size on pagy arguments
2 participants
@Paul-Bob @adrianthedev