Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dx: information on global search #3123

Merged
merged 3 commits into from
Aug 13, 2024
Merged

dx: information on global search #3123

merged 3 commits into from
Aug 13, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Aug 12, 2024 •
edited
Loading

Description

Fixes #3111
Related PR https://github.com/avo-hq/avo-pro/pull/87

global.search.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Aug 12, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Aug 12, 2024 •
edited
Loading

Code Climate has analyzed commit 22847c9 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob marked this pull request as draft August 12, 2024 11:38
@Paul-Bob Paul-Bob marked this pull request as ready for review August 12, 2024 11:40
@Paul-Bob Paul-Bob merged commit 67ad979 into main Aug 13, 2024
21 of 22 checks passed
@Paul-Bob Paul-Bob deleted the dx/information_on_global_search branch August 13, 2024 18:21
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees

@Paul-Bob Paul-Bob

Labels
Developer Experience (DX)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise information error for undefined search query on global search
2 participants
@Paul-Bob @adrianthedev