Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alignment of user actions on posts #3255

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

Aaryanpal
Copy link
Contributor

Description

Fixes #3214

Checklist:

  • I have performed a self-review of my own code

Screenshots & recording

  • ScreenCast Attatched
Bug_Fix.mp4

Copy link

codeclimate bot commented Sep 19, 2024

Code Climate has analyzed commit 8c44cfc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small piece of feedback. Thank you!

@@ -1,4 +1,4 @@
<%= content_tag :div, class: "space-x-2 flex flex-row justify-between ml-2 has-record-selector:ml-0" do %>
<%= content_tag :div, class: "#{params[:view_type] == "grid" ? "flex-wrap" : "space-x-2"} flex flex-row justify-evenly ml-2 has-record-selector:ml-0" do %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<%= content_tag :div, class: "#{params[:view_type] == "grid" ? "flex-wrap" : "space-x-2"} flex flex-row justify-evenly ml-2 has-record-selector:ml-0" do %>
<%= content_tag :div, class: "#{view_type == "grid" ? "flex-wrap" : "space-x-2"} flex flex-row justify-evenly ml-2 has-record-selector:ml-0" do %>

Can we please extract view_type inside the component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Aaryanpal!

@Paul-Bob Paul-Bob merged commit ab8d081 into avo-hq:main Oct 1, 2024
22 checks passed
@Paul-Bob Paul-Bob added the Fix label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issue with card grid view only on tabs
3 participants