Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting for key value fields #3299

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

enderahmetyurt
Copy link

@enderahmetyurt enderahmetyurt commented Oct 2, 2024

Description

Adding up and down button to sort key-value fields.

Fixes #1029

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Screen.Recording.2024-10-02.at.16.14.27.mov

Copy link

codeclimate bot commented Oct 2, 2024

Code Climate has analyzed commit d103790 and detected 0 issues on this pull request.

View more on Code Climate.

@enderahmetyurt
Copy link
Author

@adrianthedev @Paul-Bob it should be ready :)

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thank you @enderahmetyurt for this contribution!

Co-authored-by: Paul Bob <69730720+Paul-Bob@users.noreply.github.com>
@adrianthedev
Copy link
Collaborator

This is great @enderahmetyurt! Awesoem work!

There's only one thing I'd like to do more.
Move the arrows to the right side and make them blend in. Make them look like the trash icon (or even smaller if they look nice).

Thanks for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder key-value fields
3 participants