Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add automatic field detection in resources #3516

Merged
merged 24 commits into from
Jan 31, 2025
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
617ead6
feature: add automatic field detection in resources
ObiWanKeoni Dec 11, 2024
b30d05a
Merge branch 'main' into feature/automatic-field-detection
ObiWanKeoni Dec 11, 2024
3e55c88
Apply suggestions from code review
ObiWanKeoni Jan 9, 2025
f6e8b23
Optimize model enum check
ObiWanKeoni Jan 9, 2025
ac66258
Rubocop / Refactor for readability + solving problems with select inputs
ObiWanKeoni Jan 10, 2025
b5f0c6f
Fix up tags and rich texts a bit
ObiWanKeoni Jan 10, 2025
657c2da
Rubocop
ObiWanKeoni Jan 10, 2025
c76f034
Oops - use `standardrb` instead of `rubocop`
ObiWanKeoni Jan 10, 2025
3faf2da
Few more lint fixes
ObiWanKeoni Jan 10, 2025
7bc8c90
Couple more
ObiWanKeoni Jan 10, 2025
9f1bc4c
Indentation
ObiWanKeoni Jan 10, 2025
cd5c5e5
Merge branch 'main' into feature/automatic-field-detection
Paul-Bob Jan 10, 2025
4b36f1f
PR suggestions
ObiWanKeoni Jan 10, 2025
329d0c8
Lint spec file
ObiWanKeoni Jan 10, 2025
d7dd291
Remove custom resource in favor of using temporary items
ObiWanKeoni Jan 10, 2025
2ffac80
Add after blocks for cleanup
ObiWanKeoni Jan 13, 2025
a6db237
Lint
ObiWanKeoni Jan 13, 2025
0892908
Add back resource with discovered fields
ObiWanKeoni Jan 14, 2025
82fab1d
Fix status issue and remedy test setup
ObiWanKeoni Jan 16, 2025
bff6416
Merge branch 'main' into feature/automatic-field-detection
ObiWanKeoni Jan 29, 2025
5d60d7e
Update to use Avo::Mappings
ObiWanKeoni Jan 29, 2025
8abf435
Higher specificity for specs
ObiWanKeoni Jan 30, 2025
bc04386
Attempt to wait for post to load
ObiWanKeoni Jan 30, 2025
490a2e2
More reliable specs
ObiWanKeoni Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Couple more
ObiWanKeoni committed Jan 10, 2025

Verified

This commit was signed with the committer’s verified signature.
ObiWanKeoni Keoni Garner
commit 7bc8c901ab65966f0c43dd625b77df172403be00
20 changes: 10 additions & 10 deletions lib/avo/concerns/has_field_discovery.rb
Original file line number Diff line number Diff line change
@@ -52,12 +52,12 @@
class_methods do
def column_names_mapping
@column_names_mapping ||= DEFAULT_COLUMN_NAMES_MAPPING.dup
.merge(Avo.configuration.column_names_mapping || {})
.merge(Avo.configuration.column_names_mapping || {})

Check failure on line 55 in lib/avo/concerns/has_field_discovery.rb

GitHub Actions / lint / runner / standardrb

[rubocop] reported by reviewdog 🐶 [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 28) spaces for indenting an expression in an assignment spanning multiple lines. Raw Output: lib/avo/concerns/has_field_discovery.rb:55:39: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 28) spaces for indenting an expression in an assignment spanning multiple lines. .merge(Avo.configuration.column_names_mapping || {}) ^^^^^^
end

def column_types_mapping
@column_types_mapping ||= DEFAULT_COLUMN_TYPES_MAPPING.dup
.merge(Avo.configuration.column_types_mapping || {})
.merge(Avo.configuration.column_types_mapping || {})

Check failure on line 60 in lib/avo/concerns/has_field_discovery.rb

GitHub Actions / lint / runner / standardrb

[rubocop] reported by reviewdog 🐶 [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 28) spaces for indenting an expression in an assignment spanning multiple lines. Raw Output: lib/avo/concerns/has_field_discovery.rb:60:39: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 28) spaces for indenting an expression in an assignment spanning multiple lines. .merge(Avo.configuration.column_types_mapping || {}) ^^^^^^
end
end

@@ -158,14 +158,14 @@

def model_enums
@model_enums ||= if safe_model_class.respond_to?(:defined_enums)
safe_model_class.defined_enums.transform_values do |options|
{
field: :select,
options:
}
end
else
{}
safe_model_class.defined_enums.transform_values do |options|
{
field: :select,
options:
}
end
else
{}
end.with_indifferent_access
end