fix: Pagy::OverflowError

[Paul-Bob]

Description

Fixes #2468

Fixes a pagination overflow error that might occur in cases where the default query has fewer pages than the query with certain filters applied.

Let's take a simple example. Suppose that there are only 1000 employees in the system, and Johan Wang supervises 20 people, and he is viewing 10 per page, so he has 2 pages of results. If he sets the filters to show everyone (which is not the default, but is available to him) then suddenly there are 100 pages. He can advance all the way to page 100 and everything works until he resets the filters back to his default. That's when there's an error.

Originally posted by @brandondrew in #2468

---

Fixes #3522

---

Since we had fixed many Pagy::OverflowError and they still appear made me realise that we should implement a pagination fallback and reset page to 1 when overflow error is raised othwerise we can keep the current page

Related issues:

• Scopes should reset pagination #3353
• Rescue PagyOverflow Error #3352
• Reset pagination on scope change #2376
• Pagy::OverflowError expected :page in 1..1; got 3 #2284
• Pagy::OverflowError #2092
• The pagination is not reset on a filter change #2076
• [BUG] The pagination is not reset on a filter change #428

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit c3bf76d and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

[mtomov]

This is amazing, thank you for the fix!