Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print CANCEL message instead of FAIL for sriov #2911

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

vaishnavibhat
Copy link
Contributor

drmgr pci test is showing FAIL for test_drmgr_pci
this needs to be test CANCEL as sriov interface does not support drmgr -c pci option.

ls -l /sys/bus/pci/slots/ is not available for sriov interface and the hence the -c pci option is failing.

@vaishnavibhat
Copy link
Contributor Author

avocado run dlpar.py -m dlpar.py.data/dlpar.yaml --max-parallel-tasks=1
JOB ID : 750fd8b122d92b97fb4257d49ab8a19859640b7f
JOB LOG : /home/OpTest/avocado-fvt-wrapper/results/job-2024-10-23T05.45-750fd8b/job.log
(1/3) dlpar.py:DlparPci.test_dlpar;run-lpar_2-afd7: STARTED
(1/3) dlpar.py:DlparPci.test_dlpar;run-lpar_2-afd7: PASS (75.99 s)
(2/3) dlpar.py:DlparPci.test_drmgr_pci;run-lpar_2-afd7: STARTED
(2/3) dlpar.py:DlparPci.test_drmgr_pci;run-lpar_2-afd7: CANCEL: drmgr -c pci test is not supported for this device (7.71 s)
(3/3) dlpar.py:DlparPci.test_drmgr_phb;run-lpar_2-afd7: STARTED
(3/3) dlpar.py:DlparPci.test_drmgr_phb;run-lpar_2-afd7: PASS (72.53 s)
RESULTS : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 1
JOB HTML : /home/OpTest/avocado-fvt-wrapper/results/job-2024-10-23T05.45-750fd8b/results.html
JOB TIME : 195.42 s

job.log
debug.log

@vaishnavibhat vaishnavibhat changed the title print CANCEL message instead of FAIl for sriov print CANCEL message instead of FAIL for sriov Oct 23, 2024
self.do_drmgr_pci('R')
self.validation_in_os(pci)
else:
self.cancel("drmgr -c pci test is not supported for this device")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaishnavibhat can you just add only following lines at the beginning of test, instead of changing the complete block.

if self.sriov == "yes":
    self.cancel("drmgr -c pci test is not supported for this device")

@Naresh-ibm Naresh-ibm self-assigned this Oct 23, 2024
drmgr pci test is showing FAIL for test_drmgr_pci
this needs to be test CANCEL as sriov interface does not
support drmgr -c pci option.

ls -l /sys/bus/pci/slots/<SLOT> is not available for sriov interface
and the hence the -c pci option is failing.

Signed-off-by: Vaishnavi Bhat <vaishnavi@linux.vnet.ibm.com>
Copy link
Collaborator

@Naresh-ibm Naresh-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaishnavibhat Thanks for PR.
LGTM

@Naresh-ibm Naresh-ibm merged commit 5d7c4df into avocado-framework-tests:master Oct 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants