User authentication guardian #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 21, 2018 00:06
shcode
reviewed
Nov 28, 2018
lib/phoaw/auth/pipeline.ex
Outdated
| """ | ||
|
|
||
| use Guardian.Plug.Pipeline, | ||
| otp_app: :auth_ex, |
shcode
reviewed
Nov 28, 2018
| "test", | ||
| "lib/phoaw/application.ex", | ||
| "lib/phoaw_web.ex", | ||
| "lib/phoaw_web/views/error_helpers.ex" |
Collaborator
Author
There was a problem hiding this comment.
We don't use this file yet, so we didn't have test for this file
awcodify
reviewed
Nov 28, 2018
lib/phoaw/auth/auth.ex
Outdated
| alias Phoaw.Contents.User | ||
|
|
||
| def authenticate_user(username, plain_text_password) do | ||
| user = Repo.one(from u in User, where: u.username == ^username) |
Owner
There was a problem hiding this comment.
can we add method in Contents like:
Contents.find_user_by(email: 'test@example.com')
or
Contents.find_user_by_email('test@example.com')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do ?
user authentication using Guardian
What are the relevant tickets ?
#6
Where should the reviewer start ?
session_controller.exHow should this be manually tested ?
/sessions/new/usersAny background context you want to provide ?
Deployment notes
Screenshots (if appropriate)
Definition of Done:
Guardian