Fix types

src/amdb/infrastructure/persistence/alembic/migrations/env.py

@@ -41,16 +41,17 @@ def get_env(key: str) -> str:
 
 
 def get_sqlalchemy_url() -> str:
-    if not config.get_main_option("sqlalchemy.url"):
+    sqlalchemy_url = config.get_main_option("sqlalchemy.url")
+    if sqlalchemy_url is not None:
+        return sqlalchemy_url
+    else:
         host = get_env(POSTGRES_HOST_ENV)
         port = get_env(POSTGRES_PORT_ENV)
         name = get_env(POSTGRES_NAME_ENV)
         user = get_env(POSTGRES_USER_ENV)
         password = get_env(POSTGRES_PASSWORD_ENV)
 
         return f"postgresql://{user}:{password}@{host}:{port}/{name}"
-    else:
-        return config.get_main_option("sqlalchemy.url")
 
 
 def run_migrations_offline() -> None:

tests/unit/infrastructure/alembic/conftest.py

@@ -1,3 +1,5 @@
+from typing import Iterator
+
 import pytest
 import alembic.config
 import psycopg2
@@ -13,7 +15,7 @@ def alembic_config(postgres_url: str) -> alembic.config.Config:
 
 
 @pytest.fixture(scope="package", autouse=True)
-def clear_database(postgres_url: str) -> None:
+def clear_database(postgres_url: str) -> Iterator[None]:
     connection = psycopg2.connect(postgres_url)
     cursor = connection.cursor()
 

tests/unit/infrastructure/alembic/test_stairway.py

@@ -28,5 +28,5 @@ def test_migrations_stairway(alembic_config: alembic.config.Config):
         alembic.command.upgrade(alembic_config, revision.revision)
 
         # We need -1 for downgrading first migration (its down_revision is None)
-        alembic.command.downgrade(alembic_config, revision.down_revision or "-1")
+        alembic.command.downgrade(alembic_config, revision.down_revision or "-1")  # type: ignore
         alembic.command.upgrade(alembic_config, revision.revision)