fix(awful: layouts: tile: mouse_resize_handler): count the size of useless_gaps around the client (fixes #424) #3846
Conversation
…eless_gaps around the client (fixes awesomeWM#424)
Codecov Report
@@ Coverage Diff @@
## master #3846 +/- ##
==========================================
+ Coverage 91.00% 91.02% +0.01%
==========================================
Files 901 901
Lines 57532 57534 +2
==========================================
+ Hits 52358 52370 +12
+ Misses 5174 5164 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| local t = c.screen.selected_tag | ||
| local useless_gap = t.gap | ||
| local mwfact = t.master_width_factor |
There was a problem hiding this comment.
I'm not sure whether this is correct. What happens when the user selects multiple tags?
As a possible fix, we could add a params parameter like the one for arrange().
There was a problem hiding this comment.
that's existing code, see the prev lines of the diff - i've just assigned it to the variable to avoid writing c.screen..... twice
There was a problem hiding this comment.
answering your question - having two tags (with different params) selected in awesome i think not documented behavior, but i think everywhere it defaults to params of the first (by idx) of selected tags - although this PR is not the best place to discuss that behavior
| @@ -155,7 +157,7 @@ local function mouse_resize_handler(c, _, _, _, orientation) | |||
| return true | |||
| end | |||
| end | |||
| return prev_coords.x == coords.x and prev_coords.y == coords.y | |||
| return (prev_coords.x == coords.x) and (prev_coords.y == coords.y) | |||
No description provided.