Send a default action when notification is closed by user

[BarbUk]

Really fix #3182

[codecov]

Codecov Report

Merging #3863 (5daae2b) into master (aa8c7c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3863   +/-   ##
=======================================
  Coverage   91.02%   91.03%           
=======================================
  Files         901      901           
  Lines       57537    57540    +3     
=======================================
+ Hits        52372    52380    +8     
+ Misses       5165     5160    -5     

Flag	Coverage Δ
gcov	91.03% <100.00%> (+<0.01%)	⬆️
luacov	93.73% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
lib/naughty/dbus.lua	72.37% <100.00%> (+1.35%)	⬆️

... and 3 files with indirect coverage changes

[seqizz]

Thanks!

With this, looks like I can properly switching to the target channel, at least on on Slack & Telegram.

Yet I am not sure if we should include the feature (which is given here) directly into WM or leave it out.

[BarbUk]

Thanks!

With this, looks like I can properly switching to the target channel, at least on on Slack & Telegram.

I tested different notifications and applications from my side:

• chrome / gmail (with two chrome instances running): it open the correct tab/mail
• slack: open the correct channel
• mattermost: open the correct channel

So it seems to work.

Yet I am not sure if we should include the feature (which is given here) directly into WM or leave it out.

It needs more work to handle edge case I think.
I could include it in another PR under a config flag like naughty.config.follow_clicked_notification.

In any case, it should be documented somewhere if people like to jump to the right client when clicking a notification.

[actionless]

thanks 👌😺

[BarbUk]

FYI this PR fix #3182 but it's not a perfect solution as it send a default action for all notification dismissed by a user.

So if I have a notification with two actions (default, action 1, action 2), and I click on the second action, it will send:

• default
• action 2

I'll make another PR with a proper fix.