Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slider dragging signals #3884

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Slider dragging signals #3884

wants to merge 3 commits into from

Commits on Dec 31, 2023

  1. feat(w.w.slider): Add signals for the dragging state 

    When trying to hook up the slider to an external value, one would
usually have two data streams:

- `property::value` -> set external value
- external value changed -> `.value = new_value`

The problem is that without manual intervention, these two streams form
a loop, as setting `.value` also emits `property::value`.

The new set of signals is disconnected from the `value` property and its
signal and allows for more fine grained inspection of the dragging
state.

Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
    @sclu1034 @Elv13
    sclu1034 authored and Elv13 committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    5eee348 View commit details
    Browse the repository at this point in the history

  2. test(w.w.slider): Add integration tests 

    Signed-off-by: Lucas Schwiderski <lucas@lschwiderski.de>
    @sclu1034 @Elv13
    sclu1034 authored and Elv13 committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    fc9c3a5 View commit details
    Browse the repository at this point in the history

  3. test(w.w.slider): Fix integration test 

    In CI, the wibox doesn't always seem to be in the same location.
So before the actual test steps, we need to find it first.
    @sclu1034 @Elv13
    sclu1034 authored and Elv13 committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    eaff8aa View commit details
    Browse the repository at this point in the history