fix: return cached token from getValidIdToken #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mfellner! Thank you for the PR! I will change the target to canary branch and release it in upcoming canary version shortly. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures getValidIdToken and getValidCustomToken actually return the refreshed token from the cache on subsequent calls to the function.
Without this change, getValidIdToken and and getValidCustomToken only return the fresh token immediately after refreshing. Otherwise the functions return the argument serverIdToken or serverCustomToken which is likely the original, expired token. This is because internally the expiry check happens against the cached, fresh token.
The caller of getValidIdToken and and getValidCustomToken is typically not able to update the value they pass as the "initial" token in memory. For example, because it comes from a call to getTokens that is only made on a full page reload.
Fixes #291