Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware option experimental_createAnonymousUserIfUserNotFound #296

Conversation

matthova
Copy link
Contributor

Initially called out in #294

The goal of this PR is to add middleware to create a new anonymous user on initial load. It's worth debating if the additional middleware request time is worth the mess, or if this should always be done after the initial load. In any case, I learned a lot by poking at this sdk

@awinogrodzki awinogrodzki changed the base branch from main to canary December 16, 2024 10:07
@awinogrodzki
Copy link
Owner

Hey @matthova!

Thanks for the PR! I changed the target to canary branch. I'll do some adjustments and release new canary version with the changes :-)

It's worth debating if the additional middleware request time is worth the mess

If someone relies on anonymous login, they would have to make this call on the client side either way, so I think it's worth it. I am glad you marked it as experimental. It will prevent overuse of this option :-)

@awinogrodzki awinogrodzki merged commit b4b94eb into awinogrodzki:canary Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants