fix(storage): Fix rare edge case of transfer status update crash #3006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2663
Description of changes:
Attempt to fix: #2663 with minimal changes.
Concurrent Java collections aren't necessarily safe if wrapped in Kotlin mutable types (MutableList, MutableMap, MutableSet). Some of these helper operations contain multiple steps which could cause a loss of concurrency safety.
transferStatusListenerMap now contains items of ConcurrentHashMap instead of an ArrayList (The Key is important, the Boolean is just an unused placeholder. A Set would be more appropriate but attempting to keep concurrency here.
ConcurrentHashMap.newKeySet()
could have been used to make the implementation more Set like, but was concerned about the loss ofputIfAbsent
and would have had to run a multi step operation ofcontains + put
.The implementation of this class has multiple convoluted synchronization approaches and should still be tracked with an eventual full re-write to build in proper thread safety. However, this is an attempt to fix the ongoing edge-case crash in the meantime.
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.