Skip to content

chore: bump data-schema packages version (0.16.0)#1339

Closed
HuiSF wants to merge 4 commits intoaws-amplify:mainfrom
HuiSF:hui/chore/bump-data-schema
Closed

chore: bump data-schema packages version (0.16.0)#1339
HuiSF wants to merge 4 commits intoaws-amplify:mainfrom
HuiSF:hui/chore/bump-data-schema

Conversation

@HuiSF
Copy link
Member

@HuiSF HuiSF commented Apr 18, 2024

Problem

To integrate the latest changes made into @aws-amplify/data-schema and @aws-amplify/data-schema-types packages.

Issue number, if available:

Changes

  • Bump @aws-amplify/data-schema version to 0.16.0
  • Bump @aws-amplify/data-schema-types version to 0.9.0

Corresponding docs PR, if applicable:

aws-amplify/docs#7251

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 9d02d20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@aws-amplify/backend-data Patch
@aws-amplify/backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

svidgen
svidgen previously approved these changes Apr 19, 2024
@HuiSF HuiSF marked this pull request as ready for review April 19, 2024 01:36
svidgen
svidgen previously approved these changes Apr 19, 2024
@sobolk sobolk added the run-e2e Label that will include e2e tests in PR checks workflow label Apr 19, 2024
Copy link
Contributor

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix e2e tests.

@HuiSF
Copy link
Member Author

HuiSF commented Apr 19, 2024

please fix e2e tests.

I double-checked that the integration testing suite used code has been refactored to fit the newly updated Data Auth rule builder interface.

The failures in the E2E check probably were caused by the fact that the @aws-amplify/backend packages installed into the test projects is still pointing to @aws-amplify/data-schema while this PR bumps its version to 0.16.0.

@sobolk
Copy link
Contributor

sobolk commented Apr 19, 2024

please fix e2e tests.

I double-checked that the integration testing suite used code has been refactored to fit the newly updated Data Auth rule builder interface.

The failures in the E2E check probably were caused by the fact that the @aws-amplify/backend packages installed into the test projects is still pointing to @aws-amplify/data-schema while this PR bumps its version to 0.16.0.

I looked at test logs and I can see two problems:

  1. This test (https://github.com/aws-amplify/amplify-backend/actions/runs/8748311169/job/24008200339?pr=1339) failed on acquiring credentials, to mitigate this please push changes to branch in amplify-backend repo instead of fork and open new PR, this is known limitation to not allow acquiring creds if PR is from fork. I should have caught this earlier, sorry about that.
  2. This test (https://github.com/aws-amplify/amplify-backend/actions/runs/8748311169/job/24008200211?pr=1339) however does print some errors and should be investigated. See screenshot below.

image

@HuiSF
Copy link
Member Author

HuiSF commented Apr 19, 2024

This PR is created from a branch in the forked repo, which limits the E2E testing. Closing the recreate.

@HuiSF HuiSF closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-e2e Label that will include e2e tests in PR checks workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants