feat(storage): multi bucket copy #5674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equartey
reviewed
Nov 14, 2024
...rage/amplify_storage_s3_dart/lib/src/storage_s3_service/service/storage_s3_service_impl.dart
Show resolved
Hide resolved
NikaHsn
reviewed
Nov 14, 2024
|
|
||
| /// plugin specific options for `Amplify.Storage.copy`. | ||
| final StorageCopyPluginOptions? pluginOptions; | ||
|
|
||
| /// Optionally specify which bucket to target | ||
| final CopyBuckets? buckets; |
There was a problem hiding this comment.
Q: Does JS also use CopyBuckets buckets for copy API optinal param?
There was a problem hiding this comment.
No they have a different copy signature that is more extensible:
- source
- path
- bucket
- destination
- path
- bucket
I prefer their signature over ours, but it would be a breaking change to wrap our source/destination parameters in an object, so I think we stick with the CopyBuckets approach.
...rage/amplify_storage_s3_dart/lib/src/storage_s3_service/service/storage_s3_service_impl.dart
Show resolved
Hide resolved
Equartey
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.