Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add necessary write permission to closed issue message actions workflow #3419

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

atierian
Copy link
Member

Description

The closed-issue-message action added in #3374 doesn't have the necessary permissions to post a comment to an issue.

Example failure: https://github.com/aws-amplify/amplify-swift/actions/runs/7172825929/job/19530846804

This PR adds the write permission to the workflow to allow the action to carry out its duties.
This change mirrors the existing permissions used by other comment actions e.g. new_issue_maintainer

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian requested a review from a team as a code owner December 12, 2023 20:45
@codecov-commenter
Copy link

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (f8c5df9) 67.91% compared to head (d3b158e) 68.09%.
Report is 10 commits behind head on main.

Files Patch % Lines
...ify/Categories/DataStore/Query/QueryOperator.swift 0.00% 36 Missing ⚠️
...ePlugin/Migration/ModelSyncMetadataMigration.swift 81.81% 10 Missing ⚠️
...fy/Categories/DataStore/Query/QueryPredicate.swift 0.00% 9 Missing ⚠️
...Categories/DataStore/Model/Temporal/Temporal.swift 60.00% 2 Missing ⚠️
...Core/Sync/ModelSync/ModelSyncMetadata+Schema.swift 0.00% 2 Missing ⚠️
...PluginsCore/Sync/ModelSync/ModelSyncMetadata.swift 0.00% 2 Missing ⚠️
...Plugin/Sync/InitialSync/InitialSyncOperation.swift 96.22% 2 Missing ⚠️
...ataStore/Model/Internal/Model+DateFormatting.swift 0.00% 1 Missing ⚠️
...ify/Categories/DataStore/Model/Temporal/Date.swift 66.66% 1 Missing ⚠️
...Categories/DataStore/Model/Temporal/DateTime.swift 75.00% 1 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
+ Coverage   67.91%   68.09%   +0.18%     
==========================================
  Files        1083     1086       +3     
  Lines       36106    36304     +198     
==========================================
+ Hits        24520    24721     +201     
+ Misses      11586    11583       -3     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.38% <0.00%> (-0.07%) ⬇️
Amplify 48.19% <66.66%> (+0.43%) ⬆️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.06% <100.00%> (-0.16%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.93% <90.90%> (+1.16%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 78.10% <ø> (ø)
unit_tests 68.09% <77.25%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atierian atierian merged commit 0211104 into main Dec 12, 2023
76 checks passed
@atierian atierian deleted the action-comment-permissions branch December 12, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants