Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] feat(api): add support for AppSync filter attributeExists #3563

Closed
wants to merge 3 commits into from

Conversation

5d
Copy link
Member

@5d 5d commented Mar 13, 2024

Issue #

Description

  • refactor QueryPredicateOperation to enum
  • add support for AppSync filter attributeExists

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 51.10294% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 68.17%. Comparing base (9f8e690) to head (19e7d18).
Report is 3 commits behind head on main.

Files Patch % Lines
...ries/DataStore/Query/QueryPredicateOperation.swift 30.30% 46 Missing ⚠️
...egories/DataStore/Model/Internal/Persistable.swift 8.33% 33 Missing ⚠️
...mplify/Categories/DataStore/Query/QueryField.swift 12.50% 21 Missing ⚠️
...ify/Categories/DataStore/Query/QueryOperator.swift 0.00% 12 Missing ⚠️
...Plugin/Storage/SQLite/SQLStatement+Condition.swift 87.50% 9 Missing ⚠️
...ources/AWSAPIPlugin/Core/AppSyncListProvider.swift 0.00% 4 Missing ⚠️
...WSDataStorePlugin/Core/DataStoreListProvider.swift 25.00% 3 Missing ⚠️
...ePlugin/Storage/SQLite/QueryPredicate+SQLite.swift 66.66% 2 Missing ⚠️
...ries/DataStore/Query/QueryOperator+Equatable.swift 50.00% 1 Missing ⚠️
...ies/DataStore/Query/QueryPredicate+Equatable.swift 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3563      +/-   ##
==========================================
- Coverage   68.22%   68.17%   -0.05%     
==========================================
  Files        1077     1077              
  Lines       36294    36347      +53     
==========================================
+ Hits        24761    24779      +18     
- Misses      11533    11568      +35     
Flag Coverage Δ
API_plugin_unit_test 67.55% <0.00%> (+0.04%) ⬆️
AWSPluginsCore 67.10% <100.00%> (+0.20%) ⬆️
Amplify 47.87% <19.14%> (-0.23%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.02% <ø> (+0.02%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.21% <85.71%> (-0.14%) ⬇️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.10% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.61% <ø> (ø)
unit_tests 68.17% <51.10%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:40 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 14, 2024 22:41 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 00:29 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 00:29 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 00:29 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 00:29 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 00:29 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 00:29 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 00:29 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:48 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:48 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 15, 2024 03:49 — with GitHub Actions Inactive
@5d
Copy link
Member Author

5d commented Apr 11, 2024

Closing this ticket as we have opted to address this issue using a different approach.

@5d 5d closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants