Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(api): add support for GraphQL filter attributeExists" #3803

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

5d
Copy link
Contributor

@5d 5d commented Aug 8, 2024

Reverts #3484

@5d 5d requested review from a team as code owners August 8, 2024 16:50
Copy link
Contributor

github-actions bot commented Aug 8, 2024

API Breakage Report

💔 Public API Breaking Change detected:

Module: Amplify
EnumElement QueryOperator.attributeExists has been removed
Func CodingKey.attributeExists(:) has been removed
Func QueryField.attributeExists(
:) has been removed
Func QueryFieldOperation.attributeExists(_:) has been removed
Func QueryOperator.evaluate(target:) has parameter 0 type change from Any? to Any

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (0d15595) to head (aff4a88).

Files Patch % Lines
...fy/Categories/DataStore/Query/QueryPredicate.swift 0.00% 15 Missing ⚠️
...ify/Categories/DataStore/Query/QueryOperator.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3803      +/-   ##
==========================================
+ Coverage   68.51%   68.72%   +0.20%     
==========================================
  Files        1080     1080              
  Lines       37700    37616      -84     
==========================================
+ Hits        25832    25850      +18     
+ Misses      11868    11766     -102     
Flag Coverage Δ
API_plugin_unit_test 68.86% <ø> (+0.03%) ⬆️
AWSPluginsCore 68.56% <ø> (-0.12%) ⬇️
Amplify 47.59% <0.00%> (+0.21%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.74% <ø> (-0.04%) ⬇️
DataStore_plugin_unit_test 82.29% <100.00%> (+0.95%) ⬆️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 68.72% <5.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d merged commit 694aae0 into main Aug 8, 2024
80 checks passed
@5d 5d deleted the revert-3484-5d/graphql-filter-support branch August 8, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants