Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Auth) Keychain Sharing (App Reload Required) #3804

Closed
wants to merge 2 commits into from

Conversation

yaroluchko
Copy link

Issue #

#2508
#3277

Description

This allows customers to set the access group they would like the auth session to be shared on. Currently, syncing the auth session required an app restart. More work is required to make sure the auth session gets refreshed automatically within the auth state machine.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 2.22222% with 44 lines in your changes missing coverage. Please review.

Project coverage is 64.46%. Comparing base (00aac42) to head (60648a8).

Files Patch % Lines
...s/Core/AWSPluginsCore/Keychain/KeychainStore.swift 0.00% 35 Missing ⚠️
Amplify/Categories/Auth/Models/AccessGroup.swift 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3804      +/-   ##
==========================================
- Coverage   68.58%   64.46%   -4.12%     
==========================================
  Files        1080      793     -287     
  Lines       37608    27320   -10288     
==========================================
- Hits        25792    17611    -8181     
+ Misses      11816     9709    -2107     
Flag Coverage Δ
API_plugin_unit_test 68.96% <ø> (-0.04%) ⬇️
AWSPluginsCore 67.63% <2.77%> (-0.93%) ⬇️
Amplify 47.49% <0.00%> (-0.07%) ⬇️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test ?
DataStore_plugin_unit_test 82.28% <ø> (+0.75%) ⬆️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 64.46% <2.22%> (-4.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

API Breakage Report

💔 Public API Breaking Change detected:

Module: AWSPluginsCore
Constructor KeychainStore.init(service:accessGroup:) has removed default argument from parameter 1
Func KeychainStoreBehavior._getAll() has been added as a protocol requirement

@yaroluchko yaroluchko force-pushed the yaluchko/auth-keychain-sharing branch from 58389d6 to 29e7b24 Compare August 9, 2024 23:19
Copy link
Contributor

github-actions bot commented Aug 9, 2024

API Breakage Report

💔 Public API Breaking Change detected:

Module: AWSPluginsCore
Func KeychainStoreBehavior._getAll() has been added as a protocol requirement

@yaroluchko yaroluchko closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants