chore: misc ux updates

aws-amplify · Nov 27, 2023 · 8220c13 · 8220c13
1 parent 33bff1a
commit 8220c13
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 7 deletions.
diff --git a/Sources/FaceLiveness/AV/VideoChunker.swift b/Sources/FaceLiveness/AV/VideoChunker.swift
@@ -34,9 +34,9 @@ final class VideoChunker {
 
     func start() {
         guard state == .pending else { return }
-        state = .writing
         assetWriter.startWriting()
         assetWriter.startSession(atSourceTime: .zero)
+        state = .writing
     }
 
     func finish(singleFrame: @escaping (UIImage) -> Void) {

diff --git a/Sources/FaceLiveness/Views/Instruction/InstructionContainerView.swift b/Sources/FaceLiveness/Views/Instruction/InstructionContainerView.swift
@@ -97,6 +97,13 @@ struct InstructionContainerView: View {
                     argument: LocalizedStrings.challenge_verifying
                 )
             }
+        case .faceMatched:
+            InstructionView(
+                text: LocalizedStrings.challenge_instruction_hold_still,
+                backgroundColor: .livenessPrimaryBackground,
+                textColor: .livenessPrimaryLabel,
+                font: .title
+            )
         default:
             EmptyView()
         }

diff --git a/Sources/FaceLiveness/Views/Liveness/FaceLivenessDetectionView.swift b/Sources/FaceLiveness/Views/Liveness/FaceLivenessDetectionView.swift
@@ -131,13 +131,14 @@ public struct FaceLivenessDetectorView: View {
                 .onAppear {
                     Task {
                         do {
+                            let newState = disableStartView
+                            ? DisplayState.displayingLiveness
+                            : DisplayState.displayingGetReadyView
+                            guard self.displayState != newState else { return }
                             let session = try await sessionTask.value
                             viewModel.livenessService = session
                             viewModel.registerServiceEvents()
-
-                            self.displayState = disableStartView
-                            ? .displayingLiveness
-                            : .displayingGetReadyView
+                            self.displayState = newState
                         } catch {
                             throw FaceLivenessDetectionError.accessDenied
                         }
@@ -147,6 +148,7 @@ public struct FaceLivenessDetectorView: View {
         case .displayingGetReadyView:
             GetReadyPageView(
                 onBegin: {
+                    guard displayState != .displayingLiveness else { return }
                     displayState = .displayingLiveness
                 },
                 beginCheckButtonDisabled: false

diff --git a/...ceLiveness/Views/Liveness/FaceLivenessDetectionViewModel+FaceDetectionResultHandler.swift b/...ceLiveness/Views/Liveness/FaceLivenessDetectionViewModel+FaceDetectionResultHandler.swift
@@ -111,7 +111,9 @@ extension FaceLivenessDetectionViewModel: FaceDetectionResultHandler {
             case .match:
                 self.livenessState.faceMatched()
                 self.faceMatchedTimestamp = Date().timestampMilliseconds
-                self.livenessViewControllerDelegate?.displayFreshness(colorSequences: colorSequences)
+                DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) {
+                    self.livenessViewControllerDelegate?.displayFreshness(colorSequences: colorSequences)
+                }
                 let generator = UINotificationFeedbackGenerator()
                 generator.notificationOccurred(.success)
                 self.noFitStartTime = nil

diff --git a/Sources/FaceLiveness/Views/ProgressBarView.swift b/Sources/FaceLiveness/Views/ProgressBarView.swift
@@ -27,7 +27,7 @@ struct ProgressBarView: View {
                     .foregroundColor(emptyColor)
 
                 Rectangle()
-                    .cornerRadius(8, corners: [.topLeft, .bottomLeft])
+                    .cornerRadius(8, corners: .allCorners)
                     .frame(
                         width: min(percentage, 1) * proxy.size.width,
                         height: proxy.size.height - 8