Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add core-js package to react native dependencies #5908

Closed
wants to merge 2 commits into from

Conversation

chrisbonifacio
Copy link
Member

@chrisbonifacio chrisbonifacio commented Sep 19, 2023

Description of changes:

Add core-js to React Native dependencies

Related GitHub issue #, if available:

Docs Issue: #5907
JS Issue: aws-amplify/amplify-js#12070

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chrisbonifacio chrisbonifacio requested a review from a team as a code owner September 19, 2023 17:47
@katiegoines katiegoines requested a review from a team September 25, 2023 17:57
@katiegoines katiegoines added amplify/data Issue related to aws-amplify/amplify-category-api product-owner-review-needed Current step in the approval process requires a PM review labels Sep 25, 2023
@hbuchel hbuchel requested a review from renebrandel as a code owner November 15, 2023 15:08
@chrisbonifacio chrisbonifacio deleted the cbonif/fix/add-core-js-for-rn branch January 12, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/data Issue related to aws-amplify/amplify-category-api product-owner-review-needed Current step in the approval process requires a PM review react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants