Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build scripts #5949

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Update build scripts #5949

merged 4 commits into from
Oct 4, 2023

Conversation

timngyn
Copy link
Member

@timngyn timngyn commented Sep 29, 2023

Description of changes:

  • Removed unused script in package.json for building one of the deleted amplify backend lambdas we had
  • Removed the old capi workspace we had
    • The repo didn't have the capi directory and so it should be safe to remove this since we don't use workspaces on this repo
  • Add in a build script that runs the build without optimizing the images
    • This should help with local dev and also not make our Github workflow optimize the images

Staging site: https://update-build-scripts.d3kzzkiugubm89.amplifyapp.com/

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@timngyn timngyn requested a review from a team as a code owner September 29, 2023 00:07
@timngyn timngyn added the amplify/docs-engineering Issues with the docs site itself, NOT its content label Sep 29, 2023
@timngyn timngyn force-pushed the update-build-scripts branch from 2b8a62f to 1029e55 Compare October 4, 2023 20:01
@timngyn timngyn merged commit 4ac5b31 into main Oct 4, 2023
@timngyn timngyn deleted the update-build-scripts branch October 4, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/docs-engineering Issues with the docs site itself, NOT its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants