Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expander ID to event name #5963

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add expander ID to event name #5963

merged 1 commit into from
Oct 4, 2023

Conversation

timngyn
Copy link
Member

@timngyn timngyn commented Oct 4, 2023

Description of changes:

  • Add the expanderId to the event name

Staging site: https://expander-analytics.d3kzzkiugubm89.amplifyapp.com/lib/auth/getting-started/q/platform/js/

To test:

  1. Open up dev tools (make sure you have Omnibug installed)
  2. Click on an expander to open it
  3. Verify that the event captured by Omnibug has the link name as ExpanderOpen.{the title of the expander here}

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@timngyn timngyn requested a review from a team as a code owner October 4, 2023 18:03
@timngyn timngyn added the amplify/docs-engineering Issues with the docs site itself, NOT its content label Oct 4, 2023
@timngyn timngyn force-pushed the expander-analytics branch from 6760800 to fdb6807 Compare October 4, 2023 19:14
@timngyn timngyn merged commit 35cd3dd into main Oct 4, 2023
@timngyn timngyn deleted the expander-analytics branch October 4, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/docs-engineering Issues with the docs site itself, NOT its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants