Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint/ts): add command to typecheck when running yarn lint #6607

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
a8804e1
chore: remove unused utils/components/packages
hbuchel Nov 28, 2023
dda4881
initial eslint/prettier setup
hbuchel Nov 29, 2023
a66fa1e
merge RemoveUnusedCode
hbuchel Nov 28, 2023
5568a92
fix(linting errors): single quotes in text
hbuchel Nov 29, 2023
4746062
Remove WhatsNewBanner
hbuchel Nov 29, 2023
e6ec6f1
Remove WhatsNewBanner
hbuchel Nov 29, 2023
eabaab7
fix(linting errors): single quotes in text
hbuchel Nov 29, 2023
ef26faa
add rule to throw eslint error for react hooks dependencies instead o…
hbuchel Nov 29, 2023
1e125b5
Remove unused InfoPopover
hbuchel Nov 29, 2023
7eee674
Remove unused InfoPopover
hbuchel Nov 29, 2023
f65bcf5
fix(linting errors): do not pass children as prop in Block test
hbuchel Nov 29, 2023
9d9c6fb
fix(linting errors): fix next img warnings
hbuchel Nov 29, 2023
f1a1dff
fix(linting errors): missing hook dependency GetStartedPopover
hbuchel Nov 29, 2023
48d96dc
fix(linting error): move handleScroll to its own useEffect w/o depend…
hbuchel Nov 29, 2023
e9ecf32
fix(linting error): missing hook dependency in MDXCode
hbuchel Nov 29, 2023
4538920
fix(linting error): order of hooks MDXLink
hbuchel Nov 29, 2023
6c59a53
fix(linting error): missing hook dependency PlatformNavigator
hbuchel Nov 29, 2023
792a44d
fix(linting error): convert findRoute to hook, useRouteFinder, move t…
hbuchel Nov 29, 2023
c0056a6
fix(lint errors): MenuItem and type update
hbuchel Nov 29, 2023
370898d
fix(lint errors): make 3rd party scripts load async
hbuchel Nov 29, 2023
490d66f
Merge branch 'main' into SetupESLint
hbuchel Nov 29, 2023
a630015
fix(linting error): cleanup function in hook useTabKeyDetection
hbuchel Nov 29, 2023
a8570ee
change 3rd party scripts to defer
hbuchel Nov 29, 2023
2b2485d
clean up eslint warnings in next.config.mjs
hbuchel Nov 29, 2023
fa0623e
use next ExportedImage instead of Image
hbuchel Nov 29, 2023
9fb98f9
Switch awshome_s_code to async to fix track errors
hbuchel Nov 29, 2023
fa89987
add linting to staged files with husky
hbuchel Nov 30, 2023
6428534
update lintstagedrc
hbuchel Nov 30, 2023
b6050d1
Add prettier to husky precommit
hbuchel Nov 30, 2023
5ca25f0
downgrade lint-staged to v14 to work with node16
hbuchel Nov 30, 2023
6ae6057
update prettierignore
hbuchel Nov 30, 2023
700c84f
ignore mdx files for now
hbuchel Nov 30, 2023
a0ee4c4
Remove SidebarLayoutToggle
hbuchel Nov 30, 2023
38c473b
merge RemoveUnusedCode
hbuchel Nov 30, 2023
f520a5b
remove unified and mdx-prism
hbuchel Dec 1, 2023
4074610
Merge branch 'RemoveUnusedCode' into SetupESLint
hbuchel Dec 1, 2023
a7d7ddd
remove comments
hbuchel Dec 1, 2023
7b41842
add eslint ignore for 3rd party script we have to load sync
hbuchel Dec 1, 2023
859c383
merge main
hbuchel Dec 4, 2023
111432f
simplify typing for Platform
hbuchel Dec 5, 2023
4814407
add package.json script for typechecking when running yarn lint
hbuchel Dec 5, 2023
b82f0bf
merge main
hbuchel Dec 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change 3rd party scripts to defer
  • Loading branch information
hbuchel committed Nov 29, 2023

Verified

This commit was signed with the committer’s verified signature.
commit a8570eec0700c64e371ece54d0fc5a83fb97d8a7
4 changes: 2 additions & 2 deletions src/pages/_app.tsx
Original file line number Diff line number Diff line change
@@ -181,7 +181,7 @@ function MyApp({ Component, pageProps }) {
<>
<script
src="https://aa0.awsstatic.com/s_code/js/3.0/awshome_s_code.js"
async
defer
></script>
<script
src="https://alpha.d2c.marketing.aws.dev/client/loader/v1/d2c-load.js"
@@ -192,7 +192,7 @@ function MyApp({ Component, pageProps }) {
<>
<script
src="https://a0.awsstatic.com/s_code/js/3.0/awshome_s_code.js"
async
defer
></script>
<script
src="https://d2c.aws.amazon.com/client/loader/v1/d2c-load.js"
2 changes: 1 addition & 1 deletion src/pages/_document.tsx
Original file line number Diff line number Diff line change
@@ -130,7 +130,7 @@ export default class MyDocument extends Document {
/>
<script
src="https://prod.assets.shortbread.aws.dev/shortbread.js"
async
defer
></script>
<link
href="https://prod.assets.shortbread.aws.dev/shortbread.css"