a11y - change focus on click #7652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbuchel
reviewed
May 23, 2024
There was a problem hiding this comment.
Thanks @katiegoines pulled it down to test locally and have some questions/suggestions:
mainIdis defined here in Layout.tsx Can we pass that down and use it here instead of static reference?- When using a keyboard, it looks like the focus indicator flashes when focus is moved. Seems like focus is on the right element still, but we lose the visual indicator. I wonder if that's because
mainContent.focus()is happening before navigation occurs. Maybe we need this to occur in a listener foruseRouter().router.events.on('routeChangeComplete', doFocusStuff);? - The caveat for the above^ is that we don't want the focus indicator to show up if you're just mouse clicking because it's a little jarring. So maaaaaaaybe it's ok as is but it would be nice to have some visual indicator of where focus moved to. It seems to work well using a screen reader.
|
Unsure that we will move forward with this. Setting as a draft. |
|
We'd held off on this PR because we were considering replacing all next/links with tags, however testing this creates a lot of hydration errors. I recommend sticking with next/links |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
staging: https://focus-navigation.d1egzztxsxq9xz.amplifyapp.com/
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.