-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gen 2] Migrate Working with Files to Swift #7687
Conversation
…g-with-files-swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this, there are just a minor discrepancy remaining. The important part is done, which is migrating from key to path in the examples. the examples provide context to the reader while the full example is what would make sense for the reader to copy over (since it has a lot going on, the UI components, view models, etc). but they are not updated to the path. To summarize
- the full example code should be updated to use path instead of key
- the full example code has methods like
createSong(name: String, artCover: UIImage)
whose content is directly copied as the top level examples on this page. we should keep the full example code and the individual code snippets aligned - can optimize removal of guard by using
get()
. (optional improvement) - remove force unwrapping
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
…change byId to byIdentifier
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Law <1365977+lawmicha@users.noreply.github.com>
…ify/docs into cbonif/working-with-files-swift
src/pages/[platform]/build-a-backend/data/working-with-files/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
668a356
Description of changes:
Adds inline filters for Swift examples of working with files
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)
HTML:
<a href="https://docs.amplify.aws/">link</a>
When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.