Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen 2] Migrate Working with Files to Swift #7687

Merged
merged 20 commits into from
Jun 17, 2024

Conversation

chrisbonifacio
Copy link
Member

Description of changes:

Adds inline filters for Swift examples of working with files

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chrisbonifacio chrisbonifacio marked this pull request as ready for review June 11, 2024 15:32
@chrisbonifacio chrisbonifacio requested a review from a team as a code owner June 11, 2024 15:32
@chrisbonifacio chrisbonifacio requested a review from lawmicha June 11, 2024 15:40
@chrisbonifacio chrisbonifacio changed the title add inline filters for Swift [Gen 2] Migrate Working with Files to Swift Jun 11, 2024
@chrisbonifacio chrisbonifacio enabled auto-merge (squash) June 13, 2024 03:28
Copy link
Contributor

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this, there are just a minor discrepancy remaining. The important part is done, which is migrating from key to path in the examples. the examples provide context to the reader while the full example is what would make sense for the reader to copy over (since it has a lot going on, the UI components, view models, etc). but they are not updated to the path. To summarize

  • the full example code should be updated to use path instead of key
  • the full example code has methods like createSong(name: String, artCover: UIImage) whose content is directly copied as the top level examples on this page. we should keep the full example code and the individual code snippets aligned
  • can optimize removal of guard by using get(). (optional improvement)
  • remove force unwrapping

@chrisbonifacio chrisbonifacio requested a review from lawmicha June 14, 2024 20:51
lawmicha
lawmicha previously approved these changes Jun 17, 2024
renebrandel
renebrandel previously approved these changes Jun 17, 2024
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
@chrisbonifacio chrisbonifacio dismissed stale reviews from renebrandel and lawmicha via 668a356 June 17, 2024 15:45
@chrisbonifacio chrisbonifacio merged commit f0d3e66 into main Jun 17, 2024
10 of 11 checks passed
@chrisbonifacio chrisbonifacio deleted the cbonif/working-with-files-swift branch June 17, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants