Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Introduce resumable signin guide for the AmplifyJS #7976

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joon-won
Copy link
Member

@joon-won joon-won commented Sep 19, 2024

Description of changes:

  • This PR adds short introduction to a new feature for signInAPI in AmplifyJS, resumable signin

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joon-won joon-won requested a review from a team as a code owner September 19, 2024 01:23
@joon-won joon-won requested a review from josefaidt September 19, 2024 01:23
@joon-won
Copy link
Member Author

Update: Freezing this PR as we're delaying introduction of ResumableSignIn feature

@github-actions github-actions bot added redirects-needed Redirects need to be created for deleted pages deleted-assets Indicate that a PR has changes with deleted assets labels Dec 18, 2024
Copy link

mergify bot commented Dec 18, 2024

@joon-won, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)

  • What is the target address of the redirect? (Where are you trying to redirect to?)

  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

@joon-won joon-won closed this Dec 18, 2024
@joon-won joon-won force-pushed the joonwonc/add-resumable-signin-guide branch from 219f6c0 to a001291 Compare December 18, 2024 00:38
@joon-won joon-won reopened this Dec 18, 2024
…d/sign-in/index.mdx

Co-authored-by: James Jarvis <jjarvisp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deleted-assets Indicate that a PR has changes with deleted assets do-not-merge redirects-needed Redirects need to be created for deleted pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants