Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConcurrencyMode Support for StackSet Resource #123

Merged
merged 1 commit into from
May 16, 2024

Conversation

eperryAWS
Copy link
Contributor

Description of changes: This PR adds the ConcurrencyMode parameter to the AWS::CloudFormation::StackSet resource.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -35,7 +35,7 @@
<dependency>
<groupId>software.amazon.cloudformation</groupId>
<artifactId>aws-cloudformation-rpdk-java-plugin</artifactId>
<version>[2.0.0, 3.0.0)</version>
<version>[2.0.0, 2.1.0)</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this version downgrade intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are intended. It's less of a downgrade and more to prevent an upgrade. The latest versions are incompatible with the JDK version we use, so I needed to restrict it to the latest that was compatible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, that sounds good

@oshardik oshardik merged commit 0263467 into aws-cloudformation:master May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants