Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBCluster] Support add support for StorageThroughput #513

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

dbbh
Copy link
Collaborator

@dbbh dbbh commented Feb 29, 2024

This code change introduces support for GP3 storage type for Aurora engines. With the the storage types supported on Aurora engines, the database will now return a new StorageThroughput as a read-only parameter which will be set automatically by the backend. For more information, check the public documentation related to this feature:

https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-rds-general-purpose-gp3-storage-volumes/

Issue #, if available:

Description of changes:

  • Adds StorageThroughput as a read-only parameter.
  • Adds and refactors unit tests for DBCluster related to StorageThroughput and Iops
  • Includes missing stabilization on StorageThroughput for DBInstance resource which is already rolled-out.
  • Bumps RDS SDK version to 2.24.13

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@moataz-mhmd moataz-mhmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the translateDbClusterFromSdk method, I would expect to see this StorageThroughput parameter being set. This method is responsible for returning the details of a DB Cluster to CFN, including read-only parameters like DBClusterArn. It's important to set these parameters in the method because if they are not set, the customer may encounter a null exception when trying to reference them for any reason, such build condition to create another resource or configuring dependent resource.

If you want to take a look at the code implementation, you can find it here: https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds/blob/master/aws-rds-dbcluster/src/main/java/software/amazon/rds/dbcluster/Translator.java#L498-L580

documentation: https://docs.aws.amazon.com/cli/latest/reference/rds/describe-db-clusters.html

aws-rds-dbcluster/aws-rds-dbcluster.json Outdated Show resolved Hide resolved
moataz-mhmd
moataz-mhmd previously approved these changes Feb 29, 2024
@dbbh dbbh force-pushed the support-gp3-aurora branch 11 times, most recently from db54b97 to bba3364 Compare February 29, 2024 15:11
@dbbh dbbh force-pushed the support-gp3-aurora branch from bba3364 to 3a08b43 Compare February 29, 2024 15:31
@moataz-mhmd moataz-mhmd merged commit e6ba105 into aws-cloudformation:master Feb 29, 2024
1 check passed
@dbbh dbbh deleted the support-gp3-aurora branch April 9, 2024 15:58
angusy29 pushed a commit to angusy29/aws-cloudformation-resource-providers-rds that referenced this pull request Nov 6, 2024
…tion#513)

* [DBCluster] Support add support for StorageThroughput

Co-authored-by: Diogo Henriques <hendiogo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants