Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: update python runtime && edit README.md #398

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

KamilBlaz
Copy link

Issue #, if available:
#391
Description of changes:
Refactor: update runtime python && edit README.md

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mleziva
Copy link
Contributor

mleziva commented Oct 6, 2023

Hi @KamilBlaz, thanks for your contribution. I see the python runtime is being upgraded, but one of the functions uses urllib2 which has been split across several modules in Python 3.

Have you tested these changes?

@mleziva mleziva added the reviewing This PR is being reviewed label Oct 6, 2023
@KamilBlaz
Copy link
Author

Hi @KamilBlaz, thanks for your contribution. I see the python runtime is being upgraded, but one of the functions uses urllib2 which has been split across several modules in Python 3.

Have you tested these changes?

Indeed, I honestly did not notice that the library is changing. I added the new changes and tested it

@ericzbeard ericzbeard merged commit ed68d8a into aws-cloudformation:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewing This PR is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants