Skip to content

Commit

Permalink
Remove rule E2504 and add back in E3671
Browse files Browse the repository at this point in the history
  • Loading branch information
kddejong committed May 4, 2024
1 parent d15139c commit ab0b257
Show file tree
Hide file tree
Showing 258 changed files with 59,834 additions and 86,503 deletions.
1 change: 1 addition & 0 deletions scripts/fix_data_files.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/usr/bin/env python
"""
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: MIT-0
Expand Down
25 changes: 24 additions & 1 deletion scripts/update_schemas_manually.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@


common_patches = {
"BlockDeviceMapping": {"requiredXor": ["VirtualName", "Ebs", "NoDevice"]},
"BlockDeviceMapping": {
"requiredXor": ["VirtualName", "Ebs", "NoDevice"],
"cfnLint": "",
},
}

patches.extend(
Expand Down Expand Up @@ -75,6 +78,10 @@
values={"requiredXor": ["LaunchTemplateID", "LaunchTemplateName"]},
path="/definitions/LaunchTemplateSpecification",
),
Patch(
values={"pattern": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"},
path="/definitions/BlockDeviceMapping/properties/VirtualName",
),
Patch(
values={
"dependentExcluded": {
Expand Down Expand Up @@ -708,6 +715,10 @@
values=common_patches.get("BlockDeviceMapping"),
path="/definitions/BlockDeviceMapping",
),
Patch(
values={"pattern": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"},
path="/definitions/BlockDeviceMapping/properties/VirtualName",
),
Patch(
values={
"requiredXor": [
Expand All @@ -730,6 +741,10 @@
values=common_patches.get("BlockDeviceMapping"),
path="/definitions/BlockDeviceMapping",
),
Patch(
values={"pattern": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"},
path="/definitions/BlockDeviceMapping/properties/VirtualName",
),
Patch(
values={
"requiredXor": [
Expand Down Expand Up @@ -853,6 +868,10 @@
path="/definitions/BlockDeviceMapping",
values=common_patches.get("BlockDeviceMapping"),
),
Patch(
values={"pattern": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"},
path="/definitions/BlockDeviceMapping/properties/VirtualName",
),
Patch(
path="/",
values={
Expand Down Expand Up @@ -1280,6 +1299,10 @@
ResourcePatch(
resource_type="AWS::OpsWorks::Instance",
patches=[
Patch(
values={"pattern": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"},
path="/definitions/BlockDeviceMapping/properties/VirtualName",
),
Patch(
values=common_patches.get("BlockDeviceMapping"),
path="/definitions/BlockDeviceMapping",
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"a28d105c151831cc5180280626141bb0\"", "url": "https://schema.cloudformation.eu-south-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"87ecb09c34977f97745e9b9d1df416f2\"", "url": "https://schema.cloudformation.eu-south-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"2f0660e2009f6b00d8766a9928c7c884\"", "url": "https://schema.cloudformation.cn-north-1.amazonaws.com.cn/CloudformationSchema.zip"}
{"etag": "\"3a5edd35329f6d2b995d02544e9dd2c7\"", "url": "https://schema.cloudformation.cn-north-1.amazonaws.com.cn/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"e987e7b1b725a806ec977175723b7758\"", "url": "https://schema.cloudformation.us-gov-east-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"491a34104cb1bcaea7122eccef436ce2\"", "url": "https://schema.cloudformation.us-gov-east-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"16faf7f7ee2bf9b671f16907ed752da5\"", "url": "https://schema.cloudformation.me-south-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"e32684919a480c783c824ff2f4b3b12b\"", "url": "https://schema.cloudformation.me-south-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"d1530015ddd8de75f98f6429d2348b19\"", "url": "https://schema.cloudformation.us-gov-west-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"90f3a468b4e4d0300ec14e6f990dbace\"", "url": "https://schema.cloudformation.us-gov-west-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"50991ed57eec9b35aca76b739bdba942\"", "url": "https://schema.cloudformation.me-central-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"3d643298527e6ccefd6efcbacc3e9847\"", "url": "https://schema.cloudformation.me-central-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"335b476b253cf8845cd2d82319517af1\"", "url": "https://schema.cloudformation.eu-west-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"6ad1c53079b7bb6a2b759e112bf02d09\"", "url": "https://schema.cloudformation.eu-west-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"0df9abdb662a218e7acc5b80cb694d80\"", "url": "https://schema.cloudformation.cn-northwest-1.amazonaws.com.cn/CloudformationSchema.zip"}
{"etag": "\"c3fd373604988124970568e162412033\"", "url": "https://schema.cloudformation.cn-northwest-1.amazonaws.com.cn/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"4dbc3b1d393d5657c54b33b7624e465e\"", "url": "https://schema.cloudformation.af-south-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"e5a3307edb2c1adadfe89a89283041e2\"", "url": "https://schema.cloudformation.af-south-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"2dc564796fc950f2a70169718484f644\"", "url": "https://schema.cloudformation.us-west-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"bd76da37f4815a6ef15e2435d388e28f\"", "url": "https://schema.cloudformation.us-west-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"0400dcb7cf03bd5300c643f276317490\"", "url": "https://schema.cloudformation.eu-central-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"0a9e9a9a0dc6facc824f365f7e5cb16e\"", "url": "https://schema.cloudformation.eu-central-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"e6ca57fbf262f4058bd8e4e39fd59c7d\"", "url": "https://schema.cloudformation.ap-south-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"5de1938c6a1a315637d0433528217171\"", "url": "https://schema.cloudformation.ap-south-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"85c7f8f3fab2e4e4801376c02c1ba68f\"", "url": "https://schema.cloudformation.ap-southeast-4.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"4466d5555dd06ff0733c1367914e77a2\"", "url": "https://schema.cloudformation.ap-southeast-4.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"bd0f462167a4bba019eef954a321369e\"", "url": "https://schema.cloudformation.us-east-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"a75c8a73ee9a3d1f037480ba76a0a942\"", "url": "https://schema.cloudformation.us-east-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"cc2ccd1ad83ecf92920eb785d76f7029\"", "url": "https://schema.cloudformation.ap-southeast-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"37d65c736f9bb13eb531ad408e7d3765\"", "url": "https://schema.cloudformation.ap-southeast-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"952006f25873a9b8a7a484af3fb7bda1\"", "url": "https://schema.cloudformation.ap-northeast-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"35dbaed47f164a78f9bafaa4010696ae\"", "url": "https://schema.cloudformation.ap-northeast-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"02e56a71d2d9c250df2dd024cae1e6b8\"", "url": "https://schema.cloudformation.ap-southeast-3.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"0a5807abc14e8a376907922a4337fd17\"", "url": "https://schema.cloudformation.ap-southeast-3.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"309e8b2e3425d77ef67010a6c43da57b\"", "url": "https://schema.cloudformation.ap-east-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"8a07305b334d31a40ec7b60d1ce389e2\"", "url": "https://schema.cloudformation.ap-east-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"2df68147099660c918ad0e83dc356419\"", "url": "https://schema.cloudformation.sa-east-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"332c6c18239926763a973c511e2da921\"", "url": "https://schema.cloudformation.sa-east-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"5e634bc88689a8ab8bce204d0b57660d\"", "url": "https://schema.cloudformation.ap-southeast-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"71ab6babdaa5f43689ee162835b85853\"", "url": "https://schema.cloudformation.ap-southeast-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"5edcf3854aa5b8f11b6bfee1a4d2746d\"", "url": "https://schema.cloudformation.ca-west-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"0425ebf6b36faf82701e6a67d09f93c0\"", "url": "https://schema.cloudformation.ca-west-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"a7a9cb80f014475db63716061156885c\"", "url": "https://schema.cloudformation.eu-central-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"11bab7cc0eaa878fb0929059a91a4f47\"", "url": "https://schema.cloudformation.eu-central-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"5e41e68d96eef89d4e61b8ccea19d555\"", "url": "https://schema.cloudformation.eu-north-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"156cd9a4c62af3e663c11d822f84c831\"", "url": "https://schema.cloudformation.eu-north-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"7302690aedc69d50aa211855338d0a3f\"", "url": "https://schema.cloudformation.eu-south-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"462d41cac4c1019febcf5e416a092d37\"", "url": "https://schema.cloudformation.eu-south-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"48d98cdbdc1754d95d1cee26e5f9fc9d\"", "url": "https://schema.cloudformation.ca-central-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"d07b69197a7353b267a1594fd68fe728\"", "url": "https://schema.cloudformation.ca-central-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"71bb5ad5d3909700aa5473e59c4d4831\"", "url": "https://schema.cloudformation.eu-west-3.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"eec31ce6a6e65ce687c80f43463871c2\"", "url": "https://schema.cloudformation.eu-west-3.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"6289722dad60968a8b68ff63af49dbbd\"", "url": "https://schema.cloudformation.ap-northeast-3.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"41f7e03d800683886b8a15617401cf65\"", "url": "https://schema.cloudformation.ap-northeast-3.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"7b5e4274f2a1b38696dd040579a28410\"", "url": "https://schema.cloudformation.us-west-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"7ecd1fb119c7096a0aa1ed2b347cc914\"", "url": "https://schema.cloudformation.us-west-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"f4835306b0a327ec8aad04c51f0e247f\"", "url": "https://schema.cloudformation.ap-south-2.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"19942c573883fcd87cea3f49e94563ae\"", "url": "https://schema.cloudformation.ap-south-2.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"0e95510b53ab754970ddca008c67c2d4\"", "url": "https://schema.cloudformation.us-east-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"9992aea980ae84f265020ee2b43b8d64\"", "url": "https://schema.cloudformation.us-east-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"2db61544901899a81d8f39d2a550f41e\"", "url": "https://schema.cloudformation.il-central-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"c0397c91d44030174da58236513b9ebc\"", "url": "https://schema.cloudformation.il-central-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"3a0ba04189ee6bc71afa430d7b9086cf\"", "url": "https://schema.cloudformation.eu-west-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"254cb029a9a10edc92a0f8e567da79ca\"", "url": "https://schema.cloudformation.eu-west-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"etag": "\"c51c693c3184880c5f7a1d1c651adc45\"", "url": "https://schema.cloudformation.ap-northeast-1.amazonaws.com/CloudformationSchema.zip"}
{"etag": "\"7e7cd3bcdd1bcd328f57fb0537babc79\"", "url": "https://schema.cloudformation.ap-northeast-1.amazonaws.com/CloudformationSchema.zip"}
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
{
"allOf": [
{
"if": {
"properties": {
"VolumeType": {
"enum": [
"io1",
"io2"
],
"type": "string"
}
},
"required": [
"VolumeType"
]
},
"then": {
"required": [
"Iops"
]
}
},
{
"if": {
"properties": {
"VolumeType": {
"enum": [
"gp2",
"st1",
"sc1",
"standard"
],
"type": "string"
}
},
"required": [
"VolumeType"
]
},
"then": {
"properties": {
"Iops": false
}
}
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,12 @@
"value": [
"AWS::AutoScaling::AutoScalingGroup/Properties/AvailabilityZones"
]
},
{
"op": "add",
"path": "/definitions/Ebs/cfnLint",
"value": [
"AWS::AutoScaling::AutoScalingGroup/Properties/BlockDeviceMappings/Ebs"
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
"LaunchTemplateName"
]
},
{
"op": "add",
"path": "/definitions/BlockDeviceMapping/properties/VirtualName/pattern",
"value": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"
},
{
"op": "add",
"path": "/dependentExcluded",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
[
{
"op": "add",
"path": "/definitions/BlockDevice/cfnLint",
"value": [
"AWS::AutoScaling::LaunchConfiguration/Properties/BlockDeviceMappings/Ebs"
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@
"AWS::EC2::Instance/Properties/InstanceType"
]
},
{
"op": "add",
"path": "/definitions/Ebs/cfnLint",
"value": [
"AWS::EC2::Instance/Properties/BlockDeviceMappings/Ebs"
]
},
{
"op": "add",
"path": "/properties/AvailabilityZone/cfnLint",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
"NoDevice"
]
},
{
"op": "add",
"path": "/definitions/BlockDeviceMapping/properties/VirtualName/pattern",
"value": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"
},
{
"op": "add",
"path": "/requiredXor",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,12 @@
"value": [
"AWS::EC2::LaunchTemplate/LaunchTemplateData/Placement/AvailabilityZone"
]
},
{
"op": "add",
"path": "/definitions/Ebs/cfnLint",
"value": [
"AWS::EC2::LaunchTemplate/Properties/BlockDeviceMappings/Ebs"
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
"NoDevice"
]
},
{
"op": "add",
"path": "/definitions/BlockDeviceMapping/properties/VirtualName/pattern",
"value": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"
},
{
"op": "add",
"path": "/definitions/LaunchTemplateData/requiredXor",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,12 @@
"value": [
"AWS::EC2::SpotFleet/Properties/SpotFleetRequestConfigData/IamFleetRole"
]
},
{
"op": "add",
"path": "/definitions/Ebs/cfnLint",
"value": [
"AWS::EC2::SpotFleet/Properties/BlockDeviceMappings/Ebs"
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
"NoDevice"
]
},
{
"op": "add",
"path": "/definitions/BlockDeviceMapping/properties/VirtualName/pattern",
"value": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"
},
{
"op": "add",
"path": "/requiredXor",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,12 @@
"value": [
"AWS::OpsWorks::Instance/Properties/AvailabilityZone"
]
},
{
"op": "add",
"path": "/definitions/Ebs/cfnLint",
"value": [
"AWS::OpsWorks::Instance/Properties/BlockDeviceMappings/Ebs"
]
}
]
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
[
{
"op": "add",
"path": "/definitions/BlockDeviceMapping/properties/VirtualName/pattern",
"value": "^ephemeral([0-9]|[1][0-9]|[2][0-3])$"
},
{
"op": "add",
"path": "/definitions/BlockDeviceMapping/requiredXor",
Expand Down
Loading

0 comments on commit ab0b257

Please sign in to comment.