Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 Rework the last of the awsType rules #3263

Merged
merged 5 commits into from
May 24, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Rework the last of the awsType rules
  • Fix an issue with path in SnapStart

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 93.05556% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 92.64%. Comparing base (a8ce012) to head (2633217).

Files Patch % Lines
src/cfnlint/rules/outputs/Condition.py 87.50% 1 Missing and 1 partial ⚠️
src/cfnlint/rules/resources/Condition.py 87.50% 1 Missing and 1 partial ⚠️
...c/cfnlint/rules/resources/properties/Properties.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3263      +/-   ##
==========================================
- Coverage   92.73%   92.64%   -0.09%     
==========================================
  Files         308      309       +1     
  Lines       10624    10650      +26     
  Branches     2246     2246              
==========================================
+ Hits         9852     9867      +15     
- Misses        435      443       +8     
- Partials      337      340       +3     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 6af0e42 into aws-cloudformation:main May 24, 2024
21 of 22 checks passed
@kddejong kddejong deleted the v1-cleanup/2024/05/23-2 branch May 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant