Move requireXor to SpotFleetRequestConfigData #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with E3014 when checking AWS::EC2:SpotFleet resources. the original requireXor field had the correct fields but was placed at the root level of the resource instead of on the relevant definition.
kddejong
approved these changes
Oct 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3737 +/- ##
==========================================
- Coverage 93.72% 93.71% -0.01%
==========================================
Files 362 362
Lines 12341 12341
Branches 2634 2634
==========================================
- Hits 11566 11565 -1
Misses 430 430
- Partials 345 346 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with E3014 when checking
AWS::EC2:SpotFleetresources. The original requireXor field had the correct fields but was placed at the root level of the resource instead of on the relevant definition.Issue #, if available:
Description of changes:
requireXorfield to the correct place, resolving an issue where E3014 was looking for fields at the wrong layer of the resource definition.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.