Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new jsonschema keyword enumCaseInsensitive #3789

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3788

Description of changes:

  • Create a new jsonschema keyword enumCaseInsensitive
  • Update boto to use enumCaseInsensitive for certain services

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.78%. Comparing base (74847b1) to head (6b0cde5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/rules/resources/properties/Enum.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3789      +/-   ##
==========================================
- Coverage   93.79%   93.78%   -0.02%     
==========================================
  Files         363      363              
  Lines       12414    12436      +22     
  Branches     2541     2548       +7     
==========================================
+ Hits        11644    11663      +19     
  Misses        429      429              
- Partials      341      344       +3     
Flag Coverage Δ
unittests 93.74% <95.83%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit eea0801 into aws-cloudformation:main Oct 25, 2024
24 of 25 checks passed
@kddejong kddejong deleted the fix/issue/3788 branch October 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch compute environment type check case strictness
1 participant