-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate deployment files #3884
Draft
kddejong
wants to merge
7
commits into
aws-cloudformation:main
Choose a base branch
from
kddejong:fix/issue/3721
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
fix/issue/3721
branch
3 times, most recently
from
December 18, 2024 18:30
12cf66e
to
d623724
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3884 +/- ##
==========================================
+ Coverage 93.85% 93.91% +0.05%
==========================================
Files 365 376 +11
Lines 12522 12714 +192
Branches 2574 2596 +22
==========================================
+ Hits 11753 11940 +187
- Misses 424 426 +2
- Partials 345 348 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kddejong
force-pushed
the
fix/issue/3721
branch
2 times, most recently
from
December 19, 2024 22:15
9494437
to
6c18ed7
Compare
kddejong
force-pushed
the
fix/issue/3721
branch
from
December 30, 2024 21:23
6c18ed7
to
8da5f6f
Compare
kddejong
force-pushed
the
fix/issue/3721
branch
2 times, most recently
from
January 2, 2025 23:48
f7f0b77
to
1fb4877
Compare
kddejong
force-pushed
the
fix/issue/3721
branch
from
January 3, 2025 17:25
1fb4877
to
7e57f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #3721
Description of changes:
E2900
to validate parameters in a deployment file match the parameters in a templatePattern
matchesAllowedValues
match the parameter valueDefault
value the value is required in the deployment file--deployment-files
that will take a list of deployment files to validate--template-parameters
that will accept the parameters for the template being runBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.