Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-publish functionality for Function resources #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-hilaly
Copy link
Member

Fixes aws-controllers-k8s/community#2041

This patch introduces the ability for CF Functions to be automatically
published after a successful create or update operation. It adds an
annotation cloudfront.services.k8s.aws/auto-publish to the Function
resource, which when set to true, will trigger the automatic
publishing of the Function after a create or update.

Signed-off-by: Amine Hilaly hilalyamine@gmail.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly a-hilaly force-pushed the function-auto-publish branch from 3f71658 to 253c5e3 Compare March 23, 2024 14:30
@ack-prow ack-prow bot requested a review from jljaco March 23, 2024 14:30
Copy link

ack-prow bot commented Mar 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Mar 23, 2024
@a-hilaly a-hilaly force-pushed the function-auto-publish branch 8 times, most recently from ee84f66 to c04df58 Compare March 23, 2024 19:34
@a-hilaly
Copy link
Member Author

/retest

This patch introduces the ability for CF Functions to be automatically
published after a successful create or update operation. It adds an
annotation `cloudfront.services.k8s.aws/auto-publish` to the `Function`
resource, which when set to `true`, will trigger the automatic
publishing of the Function after a create or update.

Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
@a-hilaly a-hilaly force-pushed the function-auto-publish branch from c04df58 to 3f92699 Compare March 23, 2024 19:54
Copy link

ack-prow bot commented Aug 30, 2024

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
cloudfront-verify-attribution 3f92699 link true /test cloudfront-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-bot
Copy link
Collaborator

ack-bot commented Feb 26, 2025

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2025
@michaelhtm
Copy link
Member

/remove-lifecycle stale

@ack-prow ack-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudFront Function objects should be PUBLISHED or provide a field to transition their stage
3 participants