Add support for Managed Grafana v10 #28
Conversation
|
|
||
| 1. Creating a Service Account | ||
|
|
||
| ```console |
There was a problem hiding this comment.
Maybe you want to have an 'export' before this and grab the account id with jq. Theb just have this output be a bash environment variable. Then later on when the variable is used you can just say $SRC_SERVER_ACCOUNT_ID . That way people do not have to remember/scroll up and can just copy paste.
| @@ -54,12 +54,5 @@ func (a *App) Run(srcCustomGrafanaClient CustomGrafanaClient) error { | |||
| log.Info() | |||
There was a problem hiding this comment.
Is this empty log message just to create a newline? You could just start the next one with '\n' , and then remove this. That way each call to log actually has a corresponding message.
| @@ -14,15 +14,36 @@ import ( | |||
| type api interface { | |||
There was a problem hiding this comment.
I think it's a little confusing to call this package aws, especially because you are importing aws-sdk-go/aws . Can this package be named something else. maybe 'api' ? Also, can we not use the aws-sdk-go-v2 packages here? I suppose that is outside the scope of this specific pull request.
|
Thanks Kevin, all valuable feedback. I'll issue another PR for some 🧹 |
What does this PR do?
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs require unit tests
Additional Notes