feat: add self-validating workflow gate jobs #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
majanjua-amzn
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gate job that fail if any workflow job fails OR if any job is missing from the gate's needs array. Prevents both job failures and configuration drift when adding new workflow jobs.
Add CodeQL advanced config to align with ADOT Lang (e.g. https://github.com/aws-observability/aws-otel-python-instrumentation/blob/main/.github/workflows/codeql.yml), add gate job to workflow.Callout: I don't think it's possible to have one gate for both workflows, but it should not be the case that we add more over time.
CodeQL is generated by using the GitHub UI to enable advance config. I only changed
<action>@v#-><action>@<SHA>and added theall-codeql-checks-passjob, aligning with other repos.Testing:
See: aws-observability/aws-otel-python-instrumentation#477
Rollback procedure:
Revert
Ensure you've run the following tests on your changes and include the link below:
PR workflow sufficient
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.